SAMZA-2211: [Cleanup] Move RunLoop to container package#1046
Closed
mynameborat wants to merge 2 commits intoapache:masterfrom
Closed
SAMZA-2211: [Cleanup] Move RunLoop to container package#1046mynameborat wants to merge 2 commits intoapache:masterfrom
mynameborat wants to merge 2 commits intoapache:masterfrom
Conversation
prateekm
approved these changes
May 22, 2019
Contributor
prateekm
left a comment
prateekm
left a comment
There was a problem hiding this comment.
Thanks for the cleanup. Minor comments.
| } | ||
|
|
||
| void registerListener(TimerListener listener) { | ||
| public void registerListener(TimerListener listener) { |
Contributor
There was a problem hiding this comment.
Should this class be in container instead of task as well?
Contributor
Author
There was a problem hiding this comment.
I noticed we have a scheduler package and CallbackSchedulerImpl is the main consumer of this class.
Ended up moving it there. Let me know if you think we consolidate scheduler and container package.
prateekm
approved these changes
May 28, 2019
Contributor
prateekm
left a comment
prateekm
left a comment
There was a problem hiding this comment.
Thanks for the cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@prateekm @xinyuiscool please take a look